>From a718f8e1d9b4c1ccafd44782350506568f3aa140 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 8 Mar 2014 19:10:37 +0100 Subject: [PATCH 4/5] hbac-test: Use defined macros instead of strings Macro HBAC_TEST_SRCHOSTGROUP2 was defined but it was not used anywhere. --- src/tests/ipa_hbac-tests.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/tests/ipa_hbac-tests.c b/src/tests/ipa_hbac-tests.c index 3c64fe044a2902622ae46b56687da920e8872c33..a1dd2fa411dc1ce8bd53bbe1c1283dce86c477db 100644 --- a/src/tests/ipa_hbac-tests.c +++ b/src/tests/ipa_hbac-tests.c @@ -164,16 +164,18 @@ static void get_test_srchost(TALLOC_CTX *mem_ctx, new_srchost = talloc_zero(mem_ctx, struct hbac_request_element); fail_if (new_srchost == NULL); - new_srchost->name = talloc_strdup(new_srchost, "client.example.com"); + new_srchost->name = talloc_strdup(new_srchost, HBAC_TEST_SRCHOST); fail_if(new_srchost->name == NULL); new_srchost->groups = talloc_array(new_srchost, const char *, 3); fail_if(new_srchost->groups == NULL); - new_srchost->groups[0] = talloc_strdup(new_srchost->groups, "site_hosts"); + new_srchost->groups[0] = talloc_strdup(new_srchost->groups, + HBAC_TEST_SRCHOSTGROUP1); fail_if(new_srchost->groups[0] == NULL); - new_srchost->groups[1] = talloc_strdup(new_srchost->groups, "corp_hosts"); + new_srchost->groups[1] = talloc_strdup(new_srchost->groups, + HBAC_TEST_SRCHOSTGROUP2); fail_if(new_srchost->groups[1] == NULL); new_srchost->groups[2] = NULL; -- 1.8.5.3