On Wed, Aug 10, 2011 at 10:14:14AM +0200, Jan Zelený wrote:
> This patch should not be pushed to master, but I would like to
> reviewed anyway.
> It should be used to provide a custom build for users experiencing cases
> where ldap_search_ext would block (c.f.
> For example:
> export SSSD_DEBUG_LDAP_SEARCH="0xffff"
> would set LDAP_DEBUG_ANY
> The attached patch applies cleanly on the RHEL6.1 branch. I also have a
> version that applies on master/1.5 if needed.
I have three things:
On line 98 you close the original stderr - this is not a problem, but it is
On line 162 you are using strtol and testing that it did not fail. Please
consider two possibilities that you haven't considered in your patch:
- the function did not fail, but non-zero value remains in errno from previous
- the env. variable SSSD_DEBUG_LDAP_SEARCH contains empty string (I'm not sure
whether it is possible)
Other than that the patch looks fine.
Thanks, a new patch is attached.