On 06/23/2016 10:22 PM, Jakub Hrozek wrote:
On Thu, Jun 23, 2016 at 10:19:49PM +0200, Michal Židek wrote:
> On 06/23/2016 10:17 PM, Jakub Hrozek wrote:
>> On Thu, Jun 23, 2016 at 10:12:21PM +0200, Michal Židek wrote:
>>> On 06/23/2016 10:08 PM, Jakub Hrozek wrote:
>>>> On Thu, Jun 23, 2016 at 11:10:57AM +0200, Lukas Slebodnik wrote:
>>>>> @@ -217,6 +216,14 @@ int confdb_init_db(const char *config_file,
const char *config_dir,
>>>>> goto done;
>>>>> }
>>>>>
>>>>> + /* FIXME: Do not hardcode the path */
>>>>> + ret = sss_ini_call_validators(init_data,
>>>>> +
"/var/lib/sss/cfg_rules.ini");
>>>>
>>>> Why can't we use localstatedir here instead of hardcoding /var?
>>>
>>> It is fixed in the second second patch. Together with
>>> some build system changes.
>>
>> ah, OK.
>
> Btw the FIXME was not removed because it can be
> made configurable via command line option in the
> future.
>
> But I think we will never do it, so the FIXME
> line can probably be removed as well.
>
> Should I send a new patch without the FIXME?
Yes please, can you also submit it to CI?
Pushed to CI.
http://sssd-ci.idm.lab.eng.brq.redhat.com:8080/job/ci/4601/
Michal