On Wed, Jul 09, 2014 at 03:56:16PM +0200, Pavel Reichl wrote:
On Wed, 2014-07-09 at 13:02 +0200, Lukas Slebodnik wrote:
> ehlo,
>
> 1st patch fix valgrind warning
> 2nd patch fix linking of sdap-tests on platfrms with disabled link_all_deplibs
>
> LS
> _______________________________________________
> sssd-devel mailing list
> sssd-devel(a)lists.fedorahosted.org
>
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Hi,
I was just thinking if in the first patch we should also test the length
of strings: "strlen("1234") == key_len". But on the second thought I
don't think this is a good idea...we should simply assume that
sss_base64_decode returns correct size, right?
Yes, we should have (and I'm not sure we do actually) a test for
sss_base64_{encode,decode} which should be ran separately and each test
should exercise just one part of the code.
Anyway patches seems OK to me.
ACK, ACK.
master:
842f83f8db513214241a0fea076ac160b180e1dd
d528e4960bf233bc002f9676919ede196c91564c
Regards,
Pavel Reichl
_______________________________________________
sssd-devel mailing list
sssd-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel