On Wed, Apr 08, 2015 at 12:48:39PM +0200, Jakub Hrozek wrote:
On Tue, Mar 24, 2015 at 12:05:47PM +0100, Pavel Březina wrote:
> Hi,
> I'm sending these incomplete patches for review just to get some feed back.
>
> What is missing:
> - support for user's extraAttributes (although get invoker is there)
> - ListByNameFilter for both groups and users
The code is laid out well and reads good. I would like more non-error
DEBUG messages so that we can follow the code if something goes wrong
and some functions look like they could be made static. See particular
comments inline.
Also, CI tests failed on all machines:
FAIL: sbus_codegen_tests
http://sssd-ci.duckdns.org/logs/job/12/70/fedora_rawhide/ci-build-debug/c...