On Mon, Oct 20, 2014 at 03:10:12PM +0200, Pavel Březina wrote:
On 10/20/2014 03:01 PM, Pavel Březina wrote:
>On 10/20/2014 01:22 PM, Sumit Bose wrote:
>>On Fri, Oct 17, 2014 at 02:30:25PM +0200, Pavel Březina wrote:
>>>SUDO part of views.
>>
>>in general I agree with the patches,
>>
>>> From aab42216595c5edf7ca03b83de18aeb5866f10e2 Mon Sep 17 00:00:00 2001
>>>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina(a)redhat.com>
>>>Date: Fri, 17 Oct 2014 14:24:08 +0200
>>>Subject: [PATCH 2/2] sudo: support views
>>>
>>>
>>> /* check uid */
>>>- uid = ldb_msg_find_attr_as_int(user->msgs[0], SYSDB_UIDNUM, 0);
>>>+ uid = sss_view_ldb_msg_find_attr_as_int(dom, user->msgs[0],
>>>+ SYSDB_UIDNUM, 0);
>>
>>I just wonder if instead of using a drop-in replacement for
>>ldb_msg_find_attr_as_int() sss_view_ldb_msg_find_attr_as_uint64() can be
>>safely used here as well, because in general we use the *uint64() call
>>in SSSD to get UIDs and GIDs (see e.g. sysdb_get_sudo_user_info())?.
>
>I don't see why not. New patch is attached and the one that added the
>_int version is removed.
One more time - the _int version had a function prototype in previous patch.
ACK
bye,
Sumit