>From 5d572ec0e499c43416b791cf4c92ca49ca88f924 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 23 Sep 2015 13:24:53 +0200 Subject: [PATCH] IFP: Suppress warning from static analyzer It seems that clang expected that errno can change to 0 in case of error. It might be a bug in static analyzer. But the workaround does not change the logic and the errno is read just once. --- src/responder/ifp/ifp_groups.c | 4 ++-- src/responder/ifp/ifp_users.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/responder/ifp/ifp_groups.c b/src/responder/ifp/ifp_groups.c index 3060035924026641cc245f2a1970db9e2646e11c..ea48ff27a0653d3e40a7eb0a30bce85c4a8e832f 100644 --- a/src/responder/ifp/ifp_groups.c +++ b/src/responder/ifp/ifp_groups.c @@ -68,8 +68,8 @@ static errno_t ifp_groups_decompose_path(struct sss_domain_info *domains, } gid = strtouint32(parts[1], NULL, 10); - if (errno != 0) { - ret = errno; + ret = errno; + if (ret != 0) { goto done; } diff --git a/src/responder/ifp/ifp_users.c b/src/responder/ifp/ifp_users.c index effefdc0435d794206dbe7358c61d2ea47760361..7cb0f30ba7b6e2719d68ca23cfe4ae03bf4f0755 100644 --- a/src/responder/ifp/ifp_users.c +++ b/src/responder/ifp/ifp_users.c @@ -70,8 +70,8 @@ static errno_t ifp_users_decompose_path(struct sss_domain_info *domains, } uid = strtouint32(parts[1], NULL, 10); - if (errno != 0) { - ret = errno; + ret = errno; + if (ret != 0) { goto done; } -- 2.5.0