URL:
https://github.com/SSSD/sssd/pull/526
Title: #526: SSS_PYTHON: Use PyUnicode_FromString() with py3 code
lslebodn commented:
"""
On (01/03/18 16:27), fidencio wrote:
fidencio commented on this pull request.
> docobj = PyString_FromString(doc);
+#endif
@lslebodn, this is a valid issue but not related to this patch.
Please, would you mind opening a ticket for it? If you don't have the time, let me
know and I will open the ticket and assign it to myself.
I am so sorry if I overlook something but title of this pull request is:
**SSS_PYTHON: Use PyUnicode_FromString() with py3 code**
And this code should be used only with python2.6 and
never with python2.7 or python3. Because python2.7+ already have
`PyErr_NewExceptionWithDoc` and we needn't use alternative
implementation.
In another words, we are adding almost dead code for python3.
Or would you be so kind and could you explain what did I miss?
LS
"""
See the full comment at
https://github.com/SSSD/sssd/pull/526#issuecomment-369655636