On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote:
> Thanks for your review!
>
<snip>
>Thank you for the new version. I only have two comments left:
> The patch with your concers fixed is attached.
+ if (handle == NULL || errmsg == NULL) {
+ *errmsg = strerror(EINVAL);
you cannot return an error message if errmsg == NULL.
+ return -EINVAL;
+ }
+ err = sss_nss_getsidbyname(name, &sid, &id_type);
+ if (err != 0) {+ /* Might be a raw string representation of SID,
+ * try converting that before returning an error. */
+ if (sid_to_cifs_sid(ctx, name, csid) == 0)
+ return 0;
+
^^^^^^^^ trailing whitespace
+ ctx_set_error(ctx, strerror(err));
+ return -err;
+ }
bye,
Sumit