On 05/14/2010 03:11 PM, Sumit Bose wrote:
On Fri, May 14, 2010 at 08:58:39PM +0200, Sumit Bose wrote:
> On Fri, May 14, 2010 at 11:55:01AM -0400, Stephen Gallagher wrote:
>> On 05/14/2010 08:29 AM, Sumit Bose wrote:
>>> this series of patches aims to fix the handling of the info file for the
>>> locator plugin to allow a graceful fallback to the configuration from
>>> krb5.conf is the sssd backend is offline.
>>> Remove the old commit
>>> Remove references to 'online' from the main callback code,
>>> callback code to a separate file to make life easier for potential
>>> unit test.
>> Nack. Please condense be_run_offline_cb() and be_run_online_cb() into a
>> single function. They are nearly identical already.
There was an error in the new function. Ne versions attached.
> ok, I've put the common code into a new function. Most of the changes
> are in 0002.
>>> Create a new subroutine which only unlinks the files.
>> Nitpick: you added an extra "ret = EOK" into ipa_service_init()
> New versions attached.
The following two conditions don't work (tested using IPA):
1) Shutting down the SSSD with 'service sssd stop' (i.e. sending
SIGTERM) does not remove kdcinfo files.
2) When starting up online, the kdcinfo file is generated correctly on
the first request. It is removed properly when going offline (I turned
off the dirsrv on the ipa server). However, when coming back online, the
kdcinfo file is not regenerated.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.