On 01/13/2014 06:00 AM, Lukas Slebodnik wrote:
ehlo,

Attached patches fix warnings with compiler flag Wmissing-prototypes.
In my opinion, it is better declare function with static modifier if function
is not part of public API.

patch 0002-Use-static-modifier-for-unit-test-functions.patch helps me find out
that negative_test was not execupted as part of INI unit tests.

0004-REFARRAY-Move-declaration-of-ref_array_debug-to-priv.patch
It is better to have declaration in private header file, beacuse it prevents
copy&paste errors. Declaration in file ini/ini_valueobj_ut.c was wrong.

The last patch enables extra compiler warnings including Wmissing-prototypes.

LS


_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
I looked at the patches again. They seem fine.
I looks like collection has all the debug functions already exposed and public.

Let us make ref_array_debug public too as is. If it changes we will add a different function. So far I do not see a reason for it to change.

Does this simplify things?

-- 
Thank you,
Dmitri Pal

Sr. Engineering Manager for IdM portfolio
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/