-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/31/2010 09:59 AM, Jan Zelený wrote:
I'm attaching some patches fixing various minor issues found by
clang:
0001-Initialized-return-value-in-dp_copy_options.patch
Ticket: #577
ACK
0002-Fixed-potential-comparison-of-undefined-variable.patch
Ticket: #578
ACK
0003-Fixed-printing-of-undefined-value-in-sdap_async_acco.patch
Ticket: #579
Provided that it is safe to pass a NULL pointer to fprintf(), this is
OK. I know that glibc handles this, but I'm not entirely sure if that it
is good behaviour (if this would work with all possible optimalizations)
and if other libc implementations behave the same as glibc.
0004-Fixed-uninialized-value-in-proxy_id-provider.patch
Ticket: #580
I guess NSS_STATUS_UNAVAIL is as good as any of the others in this case,
so ACK
0005-Deleted-some-needless-assignments.patch
Ticket: #582
I think we should check for potential errors from sdap_id_op_done()
calls instead of removing the assignments altogether.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkx8zjsACgkQHsardTLnvCUX9QCeKF0D7f5hplx7yT2gATh897+g
B+cAnikdyJkYGrUwceHyvwUmr7dQYpn+
=MrJk
-----END PGP SIGNATURE-----