On 05/13/2010 12:07 PM, Simo Sorce wrote:
On Thu, 13 May 2010 10:56:35 -0400
Stephen Gallagher<sgallagh(a)redhat.com> wrote:
> + ret = sysdb_attrs_add_uint32(attrs, SYSDB_LDAP_ACCESS,
> + state->pam_status == PAM_SUCCESS ?
> + true :
> + false);
Just a nitpick, but normally in LDAP true false values are stored as
the strings "TRUE" or "FALSE" (upper case). It makes it clearer this
a boolean attribute than storing 0 vs a random value (usually 1).
New patch attached. I added a new sysdb function: sysdb_attrs_add_bool()
that will handle this in an ldb-compatible way.
I also corrected your other comment about passing an explicit event context.
Finally, this patch adds the new option to the SSSDConfig API and
manpages (which I forgot to do originally).
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.