On (25/07/16 12:15), Jakub Hrozek wrote:
>On Wed, Jul 20, 2016 at 12:48:16PM +0200, Sumit Bose wrote:
>> Hi,
>>
>> please find attached a fix for
https://fedorahosted.org/sssd/ticket/3103
>> which turned out to be an issue with the way SSSD generates the capaths
>> section in the krb5.conf snippet.
>>
>> bye,
>> Sumit
>>
>
>Before the patch:
>[domain_realm]
>.win.trust.test = WIN.TRUST.TEST
>win.trust.test = WIN.TRUST.TEST
>.subdom.win.trust.test = SUBDOM.WIN.TRUST.TEST
>subdom.win.trust.test = SUBDOM.WIN.TRUST.TEST
>[capaths]
>WIN.TRUST.TEST = {
> IPA.TEST = WIN.TRUST.TEST
>}
>IPA.TEST = {
> WIN.TRUST.TEST = WIN.TRUST.TEST
>}
>SUBDOM.WIN.TRUST.TEST = {
> IPA.TEST = WIN.TRUST.TEST
>}
>IPA.TEST = {
> SUBDOM.WIN.TRUST.TEST = WIN.TRUST.TEST
>}
>
>
>After the patch:
>[domain_realm]
>.win.trust.test = WIN.TRUST.TEST
>win.trust.test = WIN.TRUST.TEST
>.subdom.win.trust.test = SUBDOM.WIN.TRUST.TEST
>subdom.win.trust.test = SUBDOM.WIN.TRUST.TEST
>[capaths]
>WIN.TRUST.TEST = {
> IPA.TEST = WIN.TRUST.TEST
>}
>SUBDOM.WIN.TRUST.TEST = {
> IPA.TEST = WIN.TRUST.TEST
>}
>IPA.TEST = {
> WIN.TRUST.TEST = WIN.TRUST.TEST
> SUBDOM.WIN.TRUST.TEST = WIN.TRUST.TEST
>}
>
>The second form agrees with what is in man krb5.conf.
>
>--> ACK
>
>There are no Coverity issues found. I didn't run CI, because I have some
>issues pushing into the CI repo, but only existing files were patched and
>all the unit tests passed.
http://sssd-ci.duckdns.org/logs/job/50/10/summary.html
master:
* 66588a6241df42a04cb9ead75cf3afb38495d74a
* 2efebde7ddd5f1729a70ef4ec9de607cc393214c
* 5e40ba3168e21dbd5fa1812d6f2fc95f508a9e6e
Thanks for pushing. Unless anyone disagrees, I would prefer the patches
to go into sssd-1-13 as well.