On (12/11/15 09:10), Petr Cech wrote:
On 11/10/2015 10:44 AM, Lukas Slebodnik wrote:
>ehlo,
>
>The function gettext was not detected properly with strict
>cflags even thought it was part of glibc.
>
>sh$ CFLAGS="-Werror" ./configure
>
>sh$ grep gt_cv_func_gnugettext config.log
>gt_cv_func_gnugettext1_libc=no
>gt_cv_func_gnugettext1_libintl=no
>
>sh$ objdump -T /lib64/libc.so.6 | grep gettext
>000000000002fc60 w DF .text 0000000000000010 GLIBC_2.2.5 dcngettext
>000000000002dc70 w DF .text 000000000000000f GLIBC_2.2.5 dcgettext
>000000000002fc80 w DF .text 0000000000000016 GLIBC_2.2.5 ngettext
>000000000002dc90 w DF .text 000000000000000f GLIBC_2.2.5 gettext
>000000000002dc70 g DF .text 000000000000000f GLIBC_2.2.5 __dcgettext
>000000000002dc80 w DF .text 000000000000000a GLIBC_2.2.5 dgettext
>000000000002dc80 g DF .text 000000000000000a GLIBC_2.2.5 __dgettext
>
>With attached patch situation is better.
>q
>sh$ autoreconf
>sh$ CFLAGS="-Werror" ./configure
>
>sh$ grep gt_cv_func_gnugettext config.log
>gt_cv_func_gnugettext1_libc=yes
>
>LS
>
>0001-CONFIGURE-Bump-AM_GNU_GETTEXT_VERSION.patch
>
> From c60c2e870d140e127bca69eb03bba30988c1dec4 Mon Sep 17 00:00:00 2001
>From: Lukas Slebodnik<lslebodn(a)redhat.com>
>Date: Tue, 10 Nov 2015 10:39:07 +0100
>Subject: [PATCH] CONFIGURE: Bump AM_GNU_GETTEXT_VERSION
>
>The function gettext was not detected properly with strict
>cflags even thought it was part of glibc.
>
>sh$ CFLAGS="-Werror" ./configure
>
>sh$ grep gt_cv_func_gnugettext config.log
>gt_cv_func_gnugettext1_libc=no
>gt_cv_func_gnugettext1_libintl=no
>
>sh$ objdump -T /lib64/libc.so.6 | grep gettext
>000000000002fc60 w DF .text 0000000000000010 GLIBC_2.2.5 dcngettext
>000000000002dc70 w DF .text 000000000000000f GLIBC_2.2.5 dcgettext
>000000000002fc80 w DF .text 0000000000000016 GLIBC_2.2.5 ngettext
>000000000002dc90 w DF .text 000000000000000f GLIBC_2.2.5 gettext
>000000000002dc70 g DF .text 000000000000000f GLIBC_2.2.5 __dcgettext
>000000000002dc80 w DF .text 000000000000000a GLIBC_2.2.5 dgettext
>000000000002dc80 g DF .text 000000000000000a GLIBC_2.2.5 __dgettext
>000000000002fc70 w DF .text 000000000000000b GLIBC_2.2.5 dngettext
>---
Hi Lukas,
CI tests passed:
http://sssd-ci.duckdns.org/logs/job/32/64/summary.html
=> ACK
master:
* f0ea3ed816182fadf77f3e7f7ddb298b287007ad
sssd-1-13:
* fd311cdf3b296c932286342bd37583b6f1ccd0c6
LS