On Mon, 2012-02-13 at 13:40 +0100, Marco Pizzoli wrote:
On Mon, Feb 13, 2012 at 12:31 PM, Jakub Hrozek <jhrozek(a)redhat.com>
wrote:
On Sun, Feb 12, 2012 at 12:29:36PM +0100, Marco Pizzoli wrote:
> As I reported on the mailing list:
> - sssd.conf man page does not include "autofs" and
"ssh"
as supported
> services.
https://fedorahosted.org/sssd/ticket/1183
> - sssd-ldap.conf man page should have "not set" instead
of "none" as a
> default for the directive ldap_sasl_mech.
>
https://fedorahosted.org/sssd/ticket/1180
>
> Considered these are my first patches, I ask you to
report to me
> everything I made wrong or possibly-doable-better so I
can improve for
> future patches :-)
>
> Thanks
> Marco
Thank you very much for your contribution, Marco!
The first part is OK, but can you wrap the ssh part with a
"with_ssh"
condition the way sudo and autofs are? Something like:
+ <phrase condition="with_ssh">, ssh</phrase>
This is done in order to only include the ssh specific
documentation
when SSSD is configured with the "--with-ssh" switch.
Hi,
Ok, I understand and agree.
Now it's time for a second lesson of git :-)
How can I correct the patch? What steps do I have to follow?
re-clone from scratch? Editing the file again produce me a diff with
modified only one file...
Modify the file. Then do a 'git add <file>'. Then instead of doing
regular 'git commit', you can do 'git commit --amend'. This will add the
changes you just made to the previous commit in the list. Now just 'git
format-patch -M -C --patience --full-index -1' and you'll have a new
patch with all of your changes.
This process gets a little trickier if you have made other patches and
commits in the tree since the one you want to edit. In that case, you'll
want to learn the "ins and outs" of 'git rebase -i', but that's a
much
longer lesson. If you get to a point where you need to do that, I
recommend joining us on IRC so we can walk you through it for the first
time. We hang around on #sssd on
irc.freenode.net.