On 05/14/2010 08:29 AM, Sumit Bose wrote:
Hi,
this series of patches aims to fix the handling of the info file for the
locator plugin to allow a graceful fallback to the configuration from
krb5.conf is the sssd backend is offline.
0001-Revert-Create-kdcinfo-and-kpasswdinfo-file-at-startu.patch:
Remove the old commit
Ack.
0002-Refactor-data-provider-callbacks.patch
Remove references to 'online' from the main callback code, move
callback code to a separate file to make life easier for potential
unit test.
Ack.
0003-Add-offline-callbacks.patch
Nack. Please condense be_run_offline_cb() and be_run_online_cb() into a
single function. They are nearly identical already.
0004-Refactor-krb5_finalize.patch
Create a new subroutine which only unlinks the files.
Ack.
0005-Add-callback-to-remove-krb5-info-files-when-going-of.patch
Nack.
Nitpick: you added an extra "ret = EOK" into ipa_service_init()
0006-Krb5-locator-plugin-returns-KRB5_PLUGIN_NO_HANDLE.patch
KRB5_PLUGIN_NO_HANDLE is the error code which instructs libkrb5 to
try the next plugin of use krb5.conf.
Ack.