Title: #246: filter_users and filter_groups stop working properly in v 1.15
On Thu, Apr 27, 2017 at 1:57 PM, Pavel Březina <notifications(a)github.com>
One thing that is not exactly clear to me (and I may need your
is ... just getting the name from the DB is not enough to the the
fully-qualified name that we added to the negative cache? Do I really have
to get the cased name and replace the space?
I'm not sure from the top of my head. Please, see what's stored in the
negative cache, when you use overriden names, names with replaced space and
qualified names in filter_users and filter_groups.
I didn't test it manually but we do have tests covering those cases (and
yes, they keep passing with these changes).
I'll also do some manual tests just to be more than sure.
From a quick look into the code, I can see that we parse qualified
into shortname and domain. We also store the entries in internal fqname
format. We don't use reverse_replace_space here. An overriden name is
stored into ncache. I think you are fine with this code. But please test
it. See: sss_ncache_prepopulate.
See the full comment at https://github.com/SSSD/sssd/pull/246#issuecomment-297694425