-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 02/25/2010 01:06 PM, Jakub Hrozek wrote:
[PATCH 1/2] Reopen logs when SIGHUP is caught Upon receiving SIGHUP, the monitor signals all services to reopen their debug logs. It is also possible to signal individual services to reopen their particular files.
Nack.
This is partly my fault. update_monitor_config() is broken and dangerous. I thought I had disabled all access to it. I didn't realize it was still running with SIGHUP.
We disabled it a long while ago with the intent of fixing it eventually, but we ultimately decided that the downtime of a full restart was acceptable. I've been meaning to eliminate that code entirely.
Also, the *_rotate_logs() calls are all identical. They should just be made into a monitor_common_rotate_logs() call similar to monitor_common_res_init().
Fixes: #332
[PATCH 2/2] Package example logrotate script
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/