From 0addd298c8f1c8bed549435ea1fe01fd9cada8ed Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Thu, 23 Jun 2016 10:33:46 +0200 Subject: [PATCH 26/27] SQ: Silence Coverity warnings --- src/tools/sssctl/sssctl.c | 2 +- src/tools/sssctl/sssctl_cache.c | 2 +- src/tools/sssctl/sssctl_domains.c | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/tools/sssctl/sssctl.c b/src/tools/sssctl/sssctl.c index c10cc36191816e5323748b7e0039d88ca293b877..d0faef0c6fe920c21d936ab8d75c56b49c60ad43 100644 --- a/src/tools/sssctl/sssctl.c +++ b/src/tools/sssctl/sssctl.c @@ -52,7 +52,7 @@ sssctl_prompt(const char *message, enum sssctl_prompt_result defval) { char answer[255] = {0}; - char c; + int c; const char *yes = sssctl_prompt_str(SSSCTL_PROMPT_YES); const char *no = sssctl_prompt_str(SSSCTL_PROMPT_NO); int attempts = 0; diff --git a/src/tools/sssctl/sssctl_cache.c b/src/tools/sssctl/sssctl_cache.c index 02d91b1f11269cb1ac48d63c7d4dd390e2a3c466..b3a417379957aaf81205ceac02d7a3088e80840c 100644 --- a/src/tools/sssctl/sssctl_cache.c +++ b/src/tools/sssctl/sssctl_cache.c @@ -377,7 +377,7 @@ static errno_t sssctl_print_object(struct sssctl_object_info *info, const char *attr_value) { TALLOC_CTX *tmp_ctx; - struct sysdb_attrs *entry; + struct sysdb_attrs *entry = NULL; const char *value; errno_t ret; int i; diff --git a/src/tools/sssctl/sssctl_domains.c b/src/tools/sssctl/sssctl_domains.c index 51eeb48b444697b0a9447c1f1412ca24d767b29d..5aaaf770981a92b80b9376fd244d2d97e0502dac 100644 --- a/src/tools/sssctl/sssctl_domains.c +++ b/src/tools/sssctl/sssctl_domains.c @@ -105,6 +105,7 @@ static errno_t sssctl_domain_status_online(struct sss_tool_ctx *tool_ctx, IFACE_IFP_DOMAINS_DOMAIN_ISONLINE); if (msg == NULL) { DEBUG(SSSDBG_CRIT_FAILURE, "Unable to create D-Bus message\n"); + ret = ENOMEM; goto done; } -- 2.4.11