On 06/23/2016 08:14 PM, Jakub Hrozek wrote:
On Thu, Jun 23, 2016 at 01:51:53PM +0200, Jakub Hrozek wrote:
>> Change to src/lib/sifp/sss_simpleifp.exports is wrong.
>> Current version:
>> We cannot add new function to already released version
>> They shoudl be added to new version.
>> @see attached diff
>>
>> diff --git a/src/lib/sifp/sss_simpleifp.exports
b/src/lib/sifp/sss_simpleifp.exports
>> index 3d598fb..9fa6ecd 100644
>> --- a/src/lib/sifp/sss_simpleifp.exports
>> +++ b/src/lib/sifp/sss_simpleifp.exports
>> @@ -7,6 +7,7 @@ SSS_SIMPLEIFP_0.0 {
>> sss_sifp_init_ex;
>> sss_sifp_get_last_io_error_name;
>> sss_sifp_get_last_io_error_message;
>> + sss_sifp_strerr;
>> sss_sifp_create_message;
>> sss_sifp_send_message;
>> sss_sifp_send_message_ex;
>> @@ -14,7 +15,9 @@ SSS_SIMPLEIFP_0.0 {
>> sss_sifp_fetch_all_attrs;
>> sss_sifp_fetch_object;
>> sss_sifp_invoke_list;
>> + sss_sifp_invoke_list_ex;
>> sss_sifp_invoke_find;
>> + sss_sifp_invoke_find_ex;
>> sss_sifp_find_attr_as_bool;
>> sss_sifp_find_attr_as_int16;
>> sss_sifp_find_attr_as_uint16;
>>
>>
>> I didn't check rest of patches and I do not plant to do it :-)
>>
>> LS
>
>> diff --git a/src/lib/sifp/sss_simpleifp.exports
b/src/lib/sifp/sss_simpleifp.exports
>> index 9fa6ecd..f491092 100644
>> --- a/src/lib/sifp/sss_simpleifp.exports
>> +++ b/src/lib/sifp/sss_simpleifp.exports
>> @@ -7,7 +7,6 @@ SSS_SIMPLEIFP_0.0 {
>> sss_sifp_init_ex;
>> sss_sifp_get_last_io_error_name;
>> sss_sifp_get_last_io_error_message;
>> - sss_sifp_strerr;
>> sss_sifp_create_message;
>> sss_sifp_send_message;
>> sss_sifp_send_message_ex;
>> @@ -15,9 +14,7 @@ SSS_SIMPLEIFP_0.0 {
>> sss_sifp_fetch_all_attrs;
>> sss_sifp_fetch_object;
>> sss_sifp_invoke_list;
>> - sss_sifp_invoke_list_ex;
>> sss_sifp_invoke_find;
>> - sss_sifp_invoke_find_ex;
>> sss_sifp_find_attr_as_bool;
>> sss_sifp_find_attr_as_int16;
>> sss_sifp_find_attr_as_uint16;
>> @@ -49,3 +46,11 @@ SSS_SIMPLEIFP_0.0 {
>> local:
>> *;
>> };
>> +
>> +SSS_SIMPLEIFP_0.1 {
>> + # public functions
>> + global:
>> + sss_sifp_strerr;
>> + sss_sifp_invoke_list_ex;
>> + sss_sifp_invoke_find_ex;
>> +} SSS_SIMPLEIFP_0.0;
>
> Ugh, thanks, that's because the first version just broke the API, I
> didn't the fix the version exports properly after fixing the API..
Attached are patches I intend to push once CI and Coverity finish.
When I have badly configured SSSD (for example
domains =
nonexistent.com), I can not run sssctl
command at all. It complains that there are no properly
confiured domains even if all I wanted is
sssctl -?
to print help. Should I open a ticket to fix this
later? We may have more functionality that does
not necessarily need properly confiured SSSD in the
future.
Michal