-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/02/2010 02:40 PM, Stephen Gallagher wrote:
On 02/02/2010 11:37 AM, Sumit Bose wrote:
> On Mon, Feb 01, 2010 at 09:24:47AM -0500, Stephen Gallagher wrote:
> Nitpick:
> In the sysdb-tests, could you please add a simple check for whether
> expire_date is zero or nonzero (as appropriate). It probably wouldn't
> hurt to set the offline expiration both on and off and have a test for each.
> Otherwise the patch looks great.
>> ok, new version with extended tests is attached.
Ack.
Pushed to master.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAktogK0ACgkQeiVVYja6o6MCXACeLp0qfOhGaV0slkXIZYQUm6lj
bBUAn1qyLlsGklDfbSzJXUC/XGN6x3Qr
=XKux
-----END PGP SIGNATURE-----