On Fri, Feb 12, 2010 at 10:31:04AM -0500, Stephen Gallagher wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/12/2010 09:17 AM, Stephen Gallagher wrote:
> On 02/12/2010 08:08 AM, Stephen Gallagher wrote:
>> On 02/12/2010 08:04 AM, Sumit Bose wrote:
>>>> I have two comments:
>
>>>> +docs: all
>>>> + $(MAKE) -C server $@
>
>>>> why do I have 'make all' before I can create the docs?
>
>>>> It would be nice to get a message about missing doxygen instead of
>>>> 'true doxy.config' if doxygen is not installed.
>
>
>> Ah, these are leftovers from when I was building the docs as part of the
>> installable data (for the RPM).
>
>> We don't need the dependency on 'all', and I can change the
configure
>> test for doxygen. Replacing $(DOXYGEN) with 'true' was there to ensure
>> that 'make install' didn't fail trying to build the docs.
>
>> I will prepare a new patch.
>
> New patch attached.
>
This patch uses @echo and @exit. Otherwise it is identical to the
previous one I sent.
ACK
bye,
Sumit
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkt1dDcACgkQeiVVYja6o6NMNgCeKnwdz9+s/Pz6EG77B37mjzK3
bxcAn11ZT8wEsEcICkhKMViivwoijU+B
=yNZU
-----END PGP SIGNATURE-----