On 01/15/2014 10:30 AM, Lukas Slebodnik wrote:
On (13/01/14 10:41), Dmitri Pal wrote:
> On 01/13/2014 09:32 AM, Lukas Slebodnik wrote:
>> On (13/01/14 08:55), Dmitri Pal wrote:
>>> On 01/13/2014 05:46 AM, Lukas Slebodnik wrote:
>>>> Test negative_test was defined, but it has never been executed as part
>>>> ini_config test suite.
>>>> Simple patch is attached.
>>> This unit test tests old interfaces that is being phased out.
>>> I do not think we need to improve UNIT test for the API that is
>>> deprecated. IMO sends a wrong message so I would rather drop this.
>> it is testing old interface, but old interface is still part of library.
>> Unit test passes without any problem. Do we really need to remove this unit
>> test? Personally, I don't have problem with it.
> We need to remove unit test when we remove the old interface.
> I do not think it is time yet to remove the interface.
> But fixing unit test also does not seem like time well spent.
Unit test is not broken. So, I cannot see any problem.
Can I consider reply as ACK?
IMO it is busy work to enhance unit test for the interface being
So you can check it in but I have not tested or reviewed whether this
test does something meaningful or not. It is just a waste of time and
this is my point.
Sr. Engineering Manager for IdM portfolio
Red Hat Inc.
Looking to carve out IT costs?