URL:
https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
Lukáš,
I'm afraid you didn't understand how the usage of the GNULIB's compiler
warnings is supposed to be.
There are basically 3 essential files:
- warnings.m4
- manywarnings.m4
- sssd-compile-warnings.m4
The first two you can just get from GNULIB's git repo and update in our repo whenever
there's a update there. So, tweaking those files is something I could do, but it's
wrong per si.
There's the third file then, sssd-compile-warnings.m4, where we disable the warnings
we don't need, want or can't cope with. And in this file I've added all the
warnings we don't need, want or can't cope with. In this very same file, we check
whether a warning is or is not supported.
That's how it's supposed to work. If you think patching Makefile.am is better,
okay, just reject this patch series, open a bug and we will mark as "patches
welcome".
Again, I really don't see a valid point for rejecting this series because it
introduces 100s more in a process that takes an hour or so.
So, what's your suggestion? Can we accept the series? Can you, at least, finish
reviewing the patches that are not RHEL6 specific?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/50#issuecomment-259478258