On Mon, Sep 01, 2014 at 05:19:46PM +0200, Jakub Hrozek wrote:
On Fri, Jun 27, 2014 at 09:44:34AM +0300, Noam Meltzer wrote:
Follow patches are the code implementing design document: https://fedorahosted.org/sssd/wiki/DesignDocs/rpc.idmapd%20plugin
Changes compared to v2 of this patch:
- rebase over rev. 8ca18752 (current master)
- remove man pages from the patch (will be sent separately)
- add new contact details for plugin author
- code style
- remove sss_nfs_make_request() wrapper
- fix typo in reply_to_name(): REPLY_ID_OFFSET -> REPLY_NAME_OFFSET
Noam Meltzer (4): NEW CLIENT: plugin for NFSv4 rpc.idmapd NFSv4 client: (private) headers from libnfsidmap NFSv4 client: add to build system NFSv4 client: add to RPM spec
Makefile.am | 24 ++ configure.ac | 10 + contrib/sssd.spec.in | 7 + src/conf_macros.m4 | 30 ++ src/external/libnfsidmap.m4 | 17 + src/sss_client/nfs/nfsidmap_internal.h | 78 +++++ src/sss_client/nfs/sss_nfs_client.c | 571 +++++++++++++++++++++++++++++++++ 7 files changed, 737 insertions(+) create mode 100644 src/external/libnfsidmap.m4 create mode 100644 src/sss_client/nfs/nfsidmap_internal.h create mode 100644 src/sss_client/nfs/sss_nfs_client.c
Hi,
I asked Roland Mainz (CC-ed) to help us review the patches. Some of the discussion happened off-list, but I think the final ACK should be given on the list..
It just occured to me I should attach the final version of patches that we discussed -- there were some minor changes (such as option renaming and renaming of the plugin) that happened in my fedorapeople branch.