On (11/03/13 15:04), Pavel Brezina wrote:
> ----- Original Message -----
>> From: "Stephen Gallagher" <sgallagh(a)redhat.com>
>> To: "Development of the System Security Services Daemon"
<sssd-devel(a)lists.fedorahosted.org>
>> Sent: Monday, March 11, 2013 5:38:30 PM
>> Subject: [SSSD] [PATCH] BUILD: Fix cmocka
>>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> We were not properly detecting that cmocka was unavailable. It was
>> expecting an empty value and getting "no" instead. This patch
>> corrects the expectation, so we will now skip building and running
>> cmocka tests on platforms that do not have it available.
>>
>> Also, the common_cmocka.h header was missing from the distribution
>> tarball, causing 'make distcheck' to fail.
>
> Hi,
> thanks for the patch.
>
>> Note: the nss cmocka test is consistently segfaulting for me during
>> 'make distcheck' on F18 x86_64. I haven't had time to look into why,
>> yet. It works fine in normal 'make check', so I suspect there's
>> likely
>> something going on with permissions (since 'make check' sets $libdir
>> as read-only). But that's just a guess.
>
> This is probably the same issue we were hitting in the office today.
> Ondřej tracked it down and it looks like it's happening only with -O2.
>
> Ticket:
https://fedorahosted.org/sssd/ticket/1833
It is(was) another issue. This patch fix detection of libcmoka. So if
libcmocka is not detected, than cmocka tests will nnot be compiled. And
issue from ticket 1833 is about segfaulting during running cmocka test.
LS