On Tue, Jan 31, 2012 at 08:28:37PM -0500, Stephen Gallagher wrote:
> On Tue, 2012-01-31 at 16:02 +0100, Jakub Hrozek wrote:
> > We will want to set this option (but perhaps not
> > --enable-all-experimental-features) for F17 to be able to build the sudo
> > library.
> >
> >
https://fedorahosted.org/sssd/ticket/1145
> >
> > At the time being the option is also turned on when
> > --enable-all-experimental-features is specified.
> >
> > The second patch does the refactoring mentioned in #1145 - just moves
> > code around so that there are no #ifdefs in the main part of LDAP code.
>
> Ack to the first, Nack to the second.
>
> There's no need for ldap_sudo.c AND sdap_sudo.c.
>
I thought the difference was that the ldap_*.c files contain
one-shot initialization-time functions and the sdap_*.c files contain
the actual async functions.
> The only reason we still have ldap_*.c in the code is legacy. We
> switched to the 'sdap' prefix a long while ago to avoid potential
> conflicts (as well as confusion whether a particular file was part of
> SSSD or openldap). Just put it into sdap_sudo.c please.
>
> (One of these days we should just rename those old files to avoid
> confusion...)
New patches attached.