URL:
https://github.com/SSSD/sssd/pull/1009
Title: #1009: Use ndr_pull_steal_switch_value for modern samba versions
noelpower commented:
"""
so, it seems the earlier failures (with ingtest 'test_mod_group_gid') must have
been unrelated to the changes in this pull request. In a local build I pumped in debug
messages in any of the methods that were modified and forced that individual test to fail.
I could find no sign of the debug messages (which was at level 0) in the logs.
Additionally even inserted an 'abort()' statement into the same functions and ran
a full 'make intgcheck.
Results with and without patches were the same, nothing extra failed and no sign of of the
debug level 0 messages I inserted. (interestingly for some reason in my env I have a
single test that fails with/without these patches) but that is another issue I guess
when this was failing there were 2 failing jobs, I think the one with the failed
'intgcheck' job was fedora32 (but I am not sure now) and additionally sssd-ci I
don't know what was failing in sssd-ci (or if it is some sort of summary of other
jobs)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/1009#issuecomment-604918150