On Fri, Mar 19, 2010 at 08:48:49AM -0400, Simo Sorce wrote:
On Fri, 19 Mar 2010 12:00:47 +0100
Sumit Bose <sbose(a)redhat.com> wrote:
> On Thu, Mar 18, 2010 at 05:51:13PM -0400, Simo Sorce wrote:
> > Some time ago I added code to fetch the rootdse on connection, but
> > didn't publicize it too much.
> > Attached find 2 patches.
> > 1) Rework the way we store data fetched from the rootdse so the it
> > is more useful and is actually attached to the ldap handle.
> I'm in general fine with this one, although I haven't tested it
> throughly yet.
> > 2) Check controls are supported before using them.
> I have two comments here:
> - sdap_is_control_supported() should be integrated in
> sss_ldap_control_create() or a new call should be created which
> calls sdap_is_control_supported() and then sss_ldap_control_create().
> - the debug message 'Server does not support the Password Policy
> control' should have a much lower level than 7. Because if the
> control is missing the user might not see the expected
do you want to take over the second patch ?
I don't have a way to thoroughly test it anyway and I am a bit short on
Simo Sorce * Red Hat, Inc * New York
sssd-devel mailing list