URL:
https://github.com/SSSD/sssd/pull/5477
Title: #5477: DEBUG: Use () in program identifier instead of []
alexey-tikhonov commented:
"""
Should I then restructure the PR to not have any changes to
`debug_prg_name` and instead have simply one line removed and one added as follows?
+ "SYSLOG_IDENTIFIER=%s", program_invocation_short_name,
Btw, this is glibc/_GNU_SOURCE specific.
It appears more simple solution is to remove `SYSLOG_IDENTIFIER` completely:
systemd-journal uses program_invocation_short_name automatically in this case (I did a
quick test and
https://www.freedesktop.org/software/systemd/man/systemd.journal-fields.html seems to
confirm this: "Note that the tag is usually derived from glibc's
program_invocation_short_name variable")
This will also make implementation of `sss_log_internal()` for WITH_JOURNAL case
consistent with SYSLOG case and with `journal_send()` used in case of DEBUG() &
logger==journal (and btw imo it makes sense to add `"SSSD_PRG_NAME=sssd[%s]",
debug_prg_name` to `sss_log_internal()`, again, to be consistent).
I'd like to hear other maintainers opinion though.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5477#issuecomment-773214693