-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 08/31/2010 07:39 AM, Jan Zelený wrote:
Stephen Gallagher <sgallagh(a)redhat.com> wrote:
>>> 0003-Fixed-printing-of-undefined-value-in-sdap_async_acco.patch
>>> Ticket: #579
>>
>> Provided that it is safe to pass a NULL pointer to fprintf(), this is
>> OK. I know that glibc handles this, but I'm not entirely sure if that it
>> is good behaviour (if this would work with all possible optimalizations)
>> and if other libc implementations behave the same as glibc.
>
> This is a bug in e.g. the Intel compiler, if I remember correctly.
> Please fix fprintf. I recommend using the construct:
> name ? name : "";
> in the fprintf call.
Wouldn't it be better just to initialize the variable with "" then?
Jakub mentioned off-list that we should probably fix this in the DEBUG()
macro, rather than trying to guard against it in each possible use-case.
I think I agree with him.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAkx86zMACgkQeiVVYja6o6MQDwCfedx54FFhNnYte4iiAw5QVvNu
7DEAn2gPgpW0emk73+8A0YY1oDS1Nyee
=VO8O
-----END PGP SIGNATURE-----