On (24/07/13 09:41), Ondrej Kos wrote:
> On 07/23/2013 06:21 PM, Lukas Slebodnik wrote:
>> It would be great to have enabled printf format string checking in RHEL7.
>> Therefore I decided to send pateches for ticket
>> Patch 0001 -- Even if this patch is first, it should be applied in upstream as
>> Patch 0002 - 0006 -- trivial
>> Patch 0007 -- ssize_t is not defined in ANSI c99, IIRC it is defined in posix
>> as a signed type, therefore format should be used "zd"
>> Patch 0008 -- size_t is defined in ANSI c99 as unzigned type ->
>> Patch 0009 -- wrapper for inttypes.h and for future format macros.
>> Patch 0012 -- formating types defined in stdint.h uint_32_t ...
>> -- there are used macros defined in inttypes.h
>> Patches 0010 - 0015 fix formating for special variables (key_serial_t,
>> and for some types I created macros in sss_format.h
>> Patch 0010 -- key_serial_t is typedef of int32_t, but it could be defined
>> differently in another (platforms/ implemantations of kerberos)
>> Patch 0011 -- it seems that rlim_t us the same as uint64_t, but it was defined
>> using conditional build an not a typedef of std types.
>> Patch 0013 -- time_t is defined as "long int" sizeof_i386(time_t) !=
>> Patch 0014 -- ber_int and ber_tag are typedef for int and unsigned long
>> Patch 0015 -- gid_t and uid_t are typedef as unsigned
>> (I checked linux 32 bit, linu 64_bit and freebsd 64 bit)
>> Patch 0016 -- trivial
> I'm looking at the patches now, and I see, that somewhere you changed
> the debug levels to the new style and somewhere you left the numeric
> value. Could you please replace the debug levels with new style
> anywhere you're modifying code?
Thank you for review.
I didn't fix warnings at once, because there were a lot of warnings 180+.
So it seems, that I changed debug levels only sometimes.
Updated patches are attached.
sssd-devel mailing list
Ack to all patches
Associate Software Engineer
Identity Management - SSSD
Red Hat Czech