-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/16/2010 04:21 PM, Simo Sorce wrote:
On Thu, 16 Dec 2010 16:18:16 -0500
Simo Sorce <ssorce(a)redhat.com> wrote:
> On Thu, 16 Dec 2010 11:55:41 -0500
> Stephen Gallagher <sgallagh(a)redhat.com> wrote:
>
>> --- a/src/sss_client/pam_sss.c
>> +++ b/src/sss_client/pam_sss.c
>> @@ -413,7 +413,7 @@ static int do_pam_conversation(pam_handle_t
>> *pamh, const int msg_style, }
>> } while (state != SSS_PAM_CONV_DONE);
>>
>> - *_answer = answer;
>> + if(answer) *_answer = answer;
>
> FAIL-Style ^^^ there should be a space after the if :)
>
> However it is not clear to me how this would prevent a segfault.
>
> I think you meant it to be:
> if (_answer) *_answer = answer;
Attached find patch to fix the fix :)
Simo.
Ack and pushed to master.
Stupid typo. Thanks for catching that.
- --
Stephen Gallagher
RHCE 804006346421761
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora -
http://enigmail.mozdev.org/
iEYEARECAAYFAk0LUrQACgkQeiVVYja6o6NzDQCfTIm/L66p2WuMAyU8FoB/ETRI
09UAnjlIXNKO/Zjb3b5I3AZ1GpzBz+i7
=k216
-----END PGP SIGNATURE-----