On Wed, 2011-09-14 at 14:03 +0200, Pavel Březina wrote:
> Dne 8.9.2011 21:26, Stephen Gallagher napsal(a):
> > The output of this patch isn't very clean. I think what we really want
> > is just to have a configure flag --with-distro-version that will take
> > an arbitrary string (provided by the packager) for what they'd like to
> > see as output for the version.
>
> How about now?
This doesn't work with multi-line version strings.
I'm also re-thinking our approach here. I'd like to open this up for
discussion, but here are my new thoughts (sorry for going back and forth
on this so many times).
For this to be particularly useful, especially to developers, we should
probably make the DEFAULT version string be the base version plus a
timestamp. We could then override this for genuine releases with a
--with-release flag to configure. If no argument is provided, it would
be just the base version. If an argument is offered, it would be
concatenated to the base version.
So what we'd do instead is:
./configure (no args):
<build>
./sssd --version
sssd-1.7.0-pre201109201903Z
./configure --release
<build>
./sssd --version
sssd-1.7.0
./configure --release=-3.fc15
<build>
./sssd --version
sssd-1.7.0-3.fc15
I think this would be helpful for those of us doing development like
myself that regularly runs 'make install' from an in-progress tree.
I'm open to other suggestions, though.
I don't quite understand. Could you please elaborate what's wrong with the
original approach you suggested? That means one configure argument allowing to
specify the version with a default version string if no such argument is
provided.
Thanks
Jan