On 03/30/2011 08:44 AM, Stephen Gallagher wrote:
> On 03/29/2011 09:23 AM, Jan Zelený wrote:
>> Stephen Gallagher <sgallagh(a)redhat.com> wrote:
>>> On 03/29/2011 03:53 AM, Jan Zelený wrote:
>>>> I'm not entirely sure if I got the feature request right but in case
I
>>>> didn't I have already another patch prepared.
>>>>
>>>>
https://fedorahosted.org/sssd/ticket/700
>>>
>>> Nack.
>>>
>>> If we have explicitly set a principal, we should NOT fall back to NULL
>>> on KRB5_KT_NOTFOUND.
>>>
>>> In krb5_child_setup(), I'd rather that you send fast_principal into
>>> krb5_parse_name() and then get the realm from
>>> krb5_principal_get_realm().
>>
>> Fixed patch in attachment.
>
> Ack
Sorry, Nack.
I just noticed one small bug: at line 1473 of krb5_child.c, you 'goto
failed' without setting kerr.