Re: [SSSD] [PATCH] Better cleanup task handling

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1

On 02/23/2010 06:19 PM, Simo Sorce wrote:

Why did you change these error conditions ?

One of the versions of the patch had these conditions in a callback (there was an interim step), so I used tevent_req_error

I could swear I changed the error cases into tevent_req_post..this is a clear bug, thanks for spotting it.

You do not return on error and you are setting an error without a tevent_req_post() in the call that creates the request.

Simo.