On Thu, Oct 16, 2014 at 07:45:32PM +0200, Lukas Slebodnik wrote:
On (16/10/14 19:02), Michal Židek wrote:
>On 10/16/2014 05:25 PM, Lukas Slebodnik wrote:
>>On (16/10/14 16:19), Michal Židek wrote:
>>>Lukas requested some changes to Makefile.am
>>>and dlopen-test offline.
>>>
>>>New patches are attached.
>>>
>>>Michal
>>
>>>From e1af11faf7ba7320e90bddc855632154894b313a Mon Sep 17 00:00:00 2001
>>>From: Michal Zidek <mzidek(a)redhat.com>
>>>Date: Wed, 24 Sep 2014 16:03:04 +0200
>>>Subject: [PATCH 2/3] sss_semanage: Add mlsrange parameter to set_seuser
>>>
>>>mlsrange parameter will be needed in IPA provider
>>>and probably at some point in the tools as well.
>>>---
>>compilation will fail if sssd is built without semanage.
>>
>> CC src/util/libsss_config_la-sss_config.lo
>>./src/util/sss_semanage.c:358:5: error: conflicting types for
'set_seuser'
>> int set_seuser(const char *login_name, const char *seuser_name)
>> ^
>>In file included from ../src/util/sss_semanage.c:30:0:
>>./src/util/util.h:593:5: note: previous declaration of 'set_seuser' was
here
>> int set_seuser(const char *login_name, const char *seuser_name,
>> ^
>>Makefile:9946: recipe for target 'src/util/sss_semanage.lo' failed
>>
>>LS
>
>Sorry for that.
>
>New patches are attached.
>
>Michal
>
works fine with libsemanage and without.
ACK to all
LS
Thank you for the review. Similar to the root-drop patches, I'm going to
postpone pushing these to master until after we release 1.12.2.