On (17/09/13 10:18), Lukas Slebodnik wrote:
On (10/09/13 09:57), Lukas Slebodnik wrote:
>On (10/09/13 09:50), Lukas Slebodnik wrote:
>>On (10/09/13 09:48), Lukas Slebodnik wrote:
>>>ehlo,
>>>
>>>Although static library libsss_test_common was used only in tests,
>>>It was also built with command "make all".
>>>
>>>Simple patch is attached.
>>My hands was fast and now with patch
>>>
>>>LS
>>>_______________________________________________
>>>sssd-devel mailing list
>>>sssd-devel(a)lists.fedorahosted.org
>>>https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
>
>self NACK
>
>There is problem with linking. I had to some files cached on first time.
>
>libtool: link: cannot find the library `libsss_test_common.la' or unhandled
>argument `libsss_test_common.la'
>make[2]: *** [dyndns-tests] Error 1
>make[2]: *** Waiting for unfinished jobs....
>libtool: link: cannot find the library `libsss_test_common.la' or unhandled
>argument `libsss_test_common.la'
>
Problem was with parallel build. (make -j)
Make tries to link dyndns-tests with library libsss_test_common.a, but library
libsss_test_common.a has not been completed yet.
If we wanted to fix this, we would need to add libsss_test_common.la as a
dependency to each test. <test>_DEPENDENCIES = libsss_test_common.la
libsss_test_common.la can be build without test libraries (check. cmocka),
so it can be build within make rule "all".
If there aren't any objections, we can ignore this issue.
Problem was not in the patch itself, but because we had disabled automated
computation of build delenpencies for some tests (sysdb_tests, sysdb_ssh_tests,
nss_srv_tests. dyndns_tests). Sumit fixed this problem with patch
https://git.fedorahosted.org/cgit/sssd.git/commit/?id=16c351625346b3193e1...
s/prog_DEPENDENCIES/EXTRA_prog_DEPENDENCIES/
So, libsss_test_common can be safely moved into check_LTLIBRARIES and parallel
build will not be broken. I think it will be an advantage for other
distributions, because they don't run tests usually.
Rebased patch is attached.
LS