URL:
https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
sumit-bose commented:
"""
Hi,
the patches are looking good and the log messages, e.g shown with `systemctl status sssd`,
are now quite descriptive.
I agree that replacing `KEYTAB_CLEAN_NAME` can be handled in the different PR.
Trying with (primary=null)&(realm=null) is intended as a last resort to just pick any
principal which would mean to pick the first.
I think it is currently not worth stopping after "fatal" keytab errors, the
multiple log messages might even help to make it more clear that there is an issue which
should be fixed.
I only have a minor nitpick about ` static char buff[512];`. The `512` comes a bit out of
the blue and one might ask why not 256 or 1024? I'd like to ask you to either add a
comment that 512 is consider sufficient to store any kind of keytab description or use
something like `sizeof("FILE:")+PATH_MAX` as size.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/883#issuecomment-543225980