Title: #246: filter_users and filter_groups stop working properly in v 1.15
On Thu, Apr 27, 2017 at 10:53 AM, Pavel Březina <notifications(a)github.com>
What do we want to do in this case? It would fail with EINVAL later
when filling the grent/pwent anyways, no?
That comment should said ENOMEM. If name is NULL, sss_output_name will
return NULL and we fail with ENOMEM.
But there's no memory involved at all on sss_get_name_from_msg().
I'll follow you suggestion and update the PR anyways.
And last comment ... the introduced functions are not dealing with
cache_req_result at all. What they do is changing the ldb_result and moving
this part of the code to the cache_req_result.c does seem a little bit
weird to me.
But it still deals in some sort of result that is used but cache_reqso I
think it is ok. It deserves to be placed in separate function at least,
doesn't matter if static or incache_req_result.c`.
Okay, I'm going for a new static function cache_req_search() then.
Thanks for the review!
See the full comment at https://github.com/SSSD/sssd/pull/246#issuecomment-297655912