On (13/01/14 09:07), Dmitri Pal wrote:
On 01/13/2014 05:49 AM, Lukas Slebodnik wrote:
> Function ini_config_serialize was declared in the header file ini_configobj.h,
> but this header file was not included in implementation module ini_serialize.c
This is fine though I do not see a big reason to do this.
> Functions print_config_parsing_errors, print_file_parsing_errors were declared
> in the header file ini_config.h, but this header file was not included
> in implementation module ini_print.c
ini_config.h is the old interface
ini_configobj.h is the new interface
but problem is that implementations of functions from old interface are in the
same module (ini_print.c) like implementations of functions from old interface.
If you do not like including both header files in one module, we should file a
ticket to split file ini_print.c. It is internal change and I hope easy task.
But without this patch there will be some warnings:
ini/ini_print.c:327:6: warning: no previous prototype for
void print_file_parsing_errors(FILE *file,
ini/ini_print.c:405:6: warning: no previous prototype for
void print_config_parsing_errors(FILE *file,
These headers should not be included into one module.
They are mutually exclusive.
Functions should probably be included into ini_configobj.h but I have
not included them because they are already declared in the old interface.
So may be we should move them from old to new rather than declare them
> Simple patch is attached.
Sr. Engineering Manager for IdM portfolio
Red Hat Inc.