URL:
https://github.com/SSSD/sssd/pull/579
Title: #579: krb5 locator: add support for multiple addresses and sub-domains
jhrozek commented:
"""
The only issue I found is that the kdcinfo files are note removed when sssd exits.
One other thing we might consider is that the krb5_use_kdcinfo option can only be set in
the main domain and affects all subdomains. I /think/ that's even ultimately the right
thing to do, I can't imagine a scenario where you want the kdcinfo files for one
domain but not the other, but I think it should be mentioned during the review.
Finally, about testing, I checked that the kdcinfo files are created for all the domains
and I checked (using strace kinit) that libkrb5 is able to read all the addresses and fall
back to the next addresses in the list in case the first one does not work.
The code looks good to me, Coverity was happy as well.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/579#issuecomment-393860677