>From 3fc95f863b1ef9f2dd4c805f31c60bbb144d010d Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Thu, 26 Apr 2012 11:30:36 +0200 Subject: [PATCH 16/18] HBAC: Prevent NULL dereference in hbac_evaluate 'info' is optional parameter and can be set to NULL --- src/providers/ipa/hbac_evaluator.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/providers/ipa/hbac_evaluator.c b/src/providers/ipa/hbac_evaluator.c index a41aa5bb6f177d0ae693776866be8377104c94fd..6190fe27907d0fd4a5efbcbda7fa6c7ff2c94bbb 100644 --- a/src/providers/ipa/hbac_evaluator.c +++ b/src/providers/ipa/hbac_evaluator.c @@ -147,8 +147,10 @@ enum hbac_eval_result hbac_evaluate(struct hbac_rule **rules, } else { /* An error occurred processing this rule */ result = HBAC_EVAL_ERROR; - (*info)->code = ret; - (*info)->rule_name = strdup(rules[i]->name); + if (info) { + (*info)->code = ret; + (*info)->rule_name = strdup(rules[i]->name); + } /* Explicitly not checking the result of strdup(), since if * it's NULL, we can't do anything anyway. */ -- 1.7.7.6