>From be16a5dde03e494db3c0960321584c2c094314a9 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 25 Apr 2012 17:15:21 +0200 Subject: [PATCH 10/18] PROXY: return correct return codes We were reporting on the value of "status" instead of "ret'. We also didn't set ret to EOK in cases group contained no members. --- src/providers/proxy/proxy_id.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/providers/proxy/proxy_id.c b/src/providers/proxy/proxy_id.c index e1325b74d3f97cde38e182ec659f50aed93e185a..2e9754a2bb89429e694bb4644ff9ae5610afffcf 100644 --- a/src/providers/proxy/proxy_id.c +++ b/src/providers/proxy/proxy_id.c @@ -334,7 +334,7 @@ done: talloc_zfree(tmpctx); if (ret) { DEBUG(SSSDBG_CRIT_FAILURE, - ("proxy -> getpwuid_r failed for '%d' <%d>\n", uid, status)); + ("proxy -> getpwuid_r failed for '%d' <%d>\n", uid, ret)); } return ret; } @@ -656,6 +656,7 @@ static errno_t proxy_process_missing_users(struct sysdb_ctx *sysdb, } } + ret = EOK; done: talloc_free(tmp_ctx); return ret; @@ -849,7 +850,7 @@ done: if (ret) { DEBUG(SSSDBG_OP_FAILURE, ("proxy -> getgrnam_r failed for '%s' <%d>\n", - name, status)); + name, ret)); } return ret; } @@ -918,7 +919,7 @@ done: if (ret) { DEBUG(SSSDBG_OP_FAILURE, ("proxy -> getgrgid_r failed for '%d' <%d>\n", - gid, status)); + gid, ret)); } return ret; } -- 1.7.7.6