On 12/10/2015 11:33 AM, Lukas Slebodnik wrote:
On (10/12/15 11:26), Jakub Hrozek wrote:
> On Tue, Dec 08, 2015 at 04:57:02PM +0100, Petr Cech wrote:
>> On 12/07/2015 03:43 PM, Jakub Hrozek wrote:
>>> On Fri, Dec 04, 2015 at 04:33:51PM +0100, Petr Cech wrote:
> One style nitpick and then we can push :)
>
>> +static bool is_object_overridable(struct be_acct_req *ar)
>> +{
>> + bool ret = false;
>> +
>> + switch (ar->entry_type & BE_REQ_TYPE_MASK) {
>> + case BE_REQ_USER: ret = true;
>> + break;
>> + case BE_REQ_GROUP: ret = true;
>> + break;
>> + case BE_REQ_INITGROUPS: ret = true;
>> + break;
>> + case BE_REQ_BY_SECID: ret = true;
>> + break;
>> + case BE_REQ_USER_AND_GROUP: ret = true;
>> + break;
>> + case BE_REQ_BY_UUID: ret = true;
>> + break;
>> + case BE_REQ_BY_CERT: ret = true;
>> + break;
>> + default: break;
>> + }
>
> We can make the code more compact with:
> case BE_REQ_USER:
> case BE_REQ_GROUP:
> /* And also all the others.. */
> ret = true;
we can also use
return true;
> break;
>
>> +
>> + return ret;
>> +}
>> +
Thank you for review.
I prefer one return point per function.
Petr
PS: New patch is attached.