On Wed, Jan 20, 2016 at 09:01:35AM +0100, Lukas Slebodnik wrote:
> On (19/01/16 21:28), Jakub Hrozek wrote:
> >On Thu, Jan 14, 2016 at 01:32:02PM +0100, Sumit Bose wrote:
> >> On Thu, Jan 14, 2016 at 01:09:39PM +0100, Lukas Slebodnik wrote:
> >> > On (14/01/16 11:53), Sumit Bose wrote:
> >> > >Hi,
> >> > >
> >> > >this simple patch aims to fix
https://fedorahosted.org/sssd/ticket/2925
> >> > >which is needed for older platforms like CentOS6 or RHEL6 to allow
to
> >> > >unlock the screen with the help of a Smartcard as well.
> >> > >
> >> > >To make it more easy changeable in future I added
> >> > >https://fedorahosted.org/sssd/ticket/2926 as a reminder for me.
> >> > >
> >> > Would it be better to do it now?
> >>
> >> In general yes, but I wanted to fix a downstream issue first without
> >> adding additional options.
> >>
> >> > Because xscreensaver is not on list
> >> > or is this feature supported only on gnome?
> >>
> >> no, of course not, but so far no one complained.
> >>
> >> >
> >> > BTW we already have something similar in gpo and it should not took a
days
> >> > to implement it :-)
> >> >
> >> > man sssd-ad -> ad_gpo_map_interactive
> >>
> >> yes, I had the same in mind for the run-time configuration.
> >>
> >> bye,
> >> Sumit
> >
> >I would like to push this patch to upstream if noone complains. It's
> >better to have at least the default login manager in RHEL supported than
> >everything broken. We can continue on making the services configurable
> >later, for the 1.13.4 release so that other distributions have an easy
> >way to configure the services.
> >
> >Anyone against?
> Go ahead.
>
> I totally forgot about this ticket.
> Maybe I managed to fix #2926 today.
OK, I only ran make and make check because the CI is still crunching the
sudo patchsets. But this patch is so trivial that I think it's OK..
ACK
* master: e9c42ec738c213bd5f351567c20d404a280b32d0
* sssd-1-13: 58e388cded594c64f9d094a2b3ac374bbd860fe5