On Fri, Sep 19, 2014 at 09:26:24PM +0300, Nikolai Kondrashov wrote:
On 09/19/2014 05:15 PM, Jakub Hrozek wrote:
>On Fri, Sep 19, 2014 at 04:15:25PM +0300, Nikolai Kondrashov wrote:
>>Hi Lukas,
>>
>>On 09/19/2014 08:51 AM, Lukas Slebodnik wrote:
>>>The mock config with name default is usually symbolic link
>>>to the configuration file of local architecture. The side effect
>>>of this patch is that we will not try to rebuild on old architectures
>>>src.rpm for new architectures(fedora). It caused issues with mock tmpfs
>>>plugin.
>>
>>There is one other issue. This way we won't run RHEL6 mock builds locally
>>normally, as, AFAIK, people usually don't work on RHEL6.
>>
>>Still, we would have our CI servers.
>>
>>>+ stage mock-build mock_privileged_deps "default" \
>>>+ --resultdir ci-mock-result \
>>> rpmbuild/SRPMS/*.src.rpm
>>
>>Would it be better to perhaps name the stage just "mock"?
"mock-build" seems
>>redundant.
>>
>>Otherwise, the patch looks and works fine to me.
>>
>>Thank you, Lukas.
>>
>>There is still the problem of Clang running on all hosts. I think it will be
>>better to run it just on one. OTOH, developers might run CI on different
>>distros and Clang might produce different issues there. I see that on Fedora
>>Rawhide at least. Anyway, we can live with it for now and solve it later.
>
>Should we apply this patch atop your CI: run distro-independent patches?
No, instead of.
Thank you.
Nick
OK, pushed: 3e2f89726a90dfe091d7d7d3b558d97469e5d3af