On Thu, Aug 11, 2016 at 2:33 PM, Fabiano Fidêncio <fidencio(a)redhat.com> wrote:
I've suggested, a long time ago, that we could start making use of
GNULIB's compiler warnings from 'manywarnings' module. This is
basically what we have been doing in a few projects that I (used to
and still) maintain (like spice-gtk and libosinfo, for instance).
For now I didn't try to fix any of the warnings that we cannot cope
with, mainly because I'm not sure whether you guys will agree on using
it or not.
Here is an experimental patch that works properly on Fedora 24. I
still have to make some tests on RHEL-6, RHEL-7 and a few other
systems (Debian, at least) in order to make sure that we won't break
the build because of the patch.
If you are okay with the change, I'll start going through the warnings
that we cannot cope with and slowly start fixing them. Although, I
have the feeling that fixing some of them would cause a lot of
undesired changes, which will just bring troubles for ourselves when
backporting fixes downstream (and here I'm talking about
-Wformat-signedess, -Wsign-compare, -Wunused-parameter, ... for
I'm looking forward to hear some feedback!