URL:
https://github.com/SSSD/sssd/pull/94
Title: #94: Enable {socket,dbus}-activation for responders
fidencio commented:
"""
On Thu, Jan 19, 2017 at 1:51 PM, Pavel Březina <notifications(a)github.com>
wrote:
if (conn->last_request_time != NULL) {
time_t *last_request_time = conn->last_request_time;
*last_request_time = time(NULL);
}
This looks weird. Why did you not use simply conn->last_request_time =
time(NULL)?
Hmmm. Got reminded the reason ... :-)
Take a look on the conn structure and you'll realize that last_request_time
is not a time_t, but a time_t *.
Otherwise the code looks good. I'm glad you got rid of those
function
pointers, especially in sbus code. I need to do some testing before final
ack but I think we got there. Good job.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/SSSD/sssd/pull/94#issuecomment-273768810>, or mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AAG4ejuNBBn3fdndU6cUkNh...
.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/94#issuecomment-273923445